Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination component #322

Open
dt2patel opened this issue Sep 15, 2024 · 0 comments
Open

Pagination component #322

dt2patel opened this issue Sep 15, 2024 · 0 comments
Assignees
@R-Sourabh
Labels
enhancement New feature or request

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

For long lists need to have the option to do pagination on view. Will require API support, but here is UI component:

Screenshot 2024-09-15 at 3 25 43 PM
@dt2patel dt2patel added the enhancement New feature or request label Sep 15, 2024
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Sep 16, 2024
@ravilodhi ravilodhi assigned R-Sourabh and unassigned ravilodhi Jan 13, 2025
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jan 13, 2025
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 15, 2025
@R-Sourabh
Implemented: Dxp pagination component(hotwax#322)
1f589bf
@R-Sourabh R-Sourabh mentioned this issue Jan 15, 2025
Merged
3 tasks
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 15, 2025
@R-Sourabh R-Sourabh moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Jan 16, 2025
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 16, 2025
@R-Sourabh
Created a single function to handle page changes and updated the logi…
d45d33d 
…c of the getDisplayedPageCounts function (hotwax#322)
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 16, 2025
@R-Sourabh
Improved: replaced 'selected-page' class from page buttons & made pag…
9533392 
…e count button size proeprty dynamic(hotwax#322)
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 16, 2025
@R-Sourabh
Improved: replaced the pageCount keyword with pageIndex(hotwax#322)
9e4ee4d
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 16, 2025
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 16, 2025
@R-Sourabh
Improved: Removed the changePage function, which was calling updateCu…
bb3d270 
…rrentPage, and directly invoked updateCurrentPage from the template(hotwax#322)

- Renamed the emitter from 'updatePageCount' to 'updatePageIndex' and the function name from 'getDisplayedPageCounts' to 'getDisplayedPageIndexes'.
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: Fixed the typo in the function name getDisplayedPageIndexes (…
8cb357d 
…hotwax#322)
ymaheshwari1 added a commit that referenced this issue Jan 17, 2025
@ymaheshwari1
Merge pull request #356 from R-Sourabh/#322-dxp-pagination
d2a96a6 
Implemented: Dxp pagination component(#322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-Sourabh R-Sourabh

Labels
enhancement New feature or request
Projects
Digital Experience Platform
Status: 👀 In review
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ravilodhi @dt2patel @R-Sourabh