Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Empty State When Adding Product Count or Searching with No Results #338

Closed
Adameddy26 opened this issue Jul 4, 2024 · 1 comment
Closed

No Empty State When Adding Product Count or Searching with No Results #338

Adameddy26 opened this issue Jul 4, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.0.0

Comments

@Adameddy26
Copy link

Current behavior

The UI does not display any empty state message or indication, leading to potential user confusion.

Expected behavior

An empty state message or UI element should be displayed, indicating that no products match the search criteria when attempting to add a product count.

Steps to reproduce the issue

Navigate to the pending review tab.
Attempt to add a product count.
Enter a search term in the product search bar that does not match any existing products.
Observe the UI response when no results are found.

Environment details

App environment : DEV
@Adameddy26 Adameddy26 added the bug Something isn't working label Jul 4, 2024
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 5, 2024
@R-Sourabh
Improved: Displayed an empty state message or UI element indicating n…
0936715 
…o products match the search criteria(hotwax#338)
@R-Sourabh R-Sourabh mentioned this issue Aug 5, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 5, 2024
@R-Sourabh
Improved: added checks on showing variance & re-count button on Produ…
1953002 
…ct detail section(hotwax#338)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 5, 2024
@R-Sourabh
Revert "Improved: added checks on showing variance & re-count button …
c7e0cca 
…on Product detail section(hotwax#338)"

This reverts commit 1953002.
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 14, 2024
@R-Sourabh
Improved: resolved the comment and change the local variable name(hot…
e465892 
…wax#338)
ymaheshwari1 added a commit that referenced this issue Aug 14, 2024
@ymaheshwari1
Merge pull request #415 from R-Sourabh/#338-empty-state-pending-review
090b568 
Improved: Displayed an empty state message or UI element indicating no products match the search criteria(#338)
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Aug 26, 2024
@Adameddy26
Copy link
Author

Verified and working fine in release v2.0.0. Hence, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.0.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@R-Sourabh @Adameddy26