Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counting detail page UI Revamp #357

Closed
dt2patel opened this issue Jul 12, 2024 · 1 comment
Closed

Counting detail page UI Revamp #357

dt2patel opened this issue Jul 12, 2024 · 1 comment
Assignees
@Adameddy26
Labels
enhancement New feature or request release-v2.0.0

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Few points for the count detail page:

Change primary product id to H1 tag
Change save count button to primary filled button not outline
Add next and back buttons on the count detail screen (fixed to do not scroll with products)
Add scroll snapping so that if user scrolls down on the detail section, they land on the next product

Screenshot 2024-07-12 at 3 34 45 PM
@ravilodhi ravilodhi assigned R-Sourabh and unassigned ravilodhi Jul 15, 2024
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 16, 2024
@R-Sourabh
Implemented: Add next and back buttons on the count detail screen (ho…
927bbd7 
…twax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 17, 2024
@R-Sourabh
Merge branch 'hotwax#353-sticky-scrolling' into hotwax#357-counting-d…
8bca84f 
…etail-revamp
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 17, 2024
@R-Sourabh
Implemented: added scroll snapping so that if user scrolls down on th…
28ddb07 
…e detail section, they land on the next product(hotwax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 22, 2024
@R-Sourabh
Implemented: Scrolling on the product detail section of count detail …
9bc98bc 
…page & deprecated the product detail component(hotwax#357)()
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 24, 2024
@R-Sourabh
Improved: enabled scroll snapping and smooth scrolling on the count d…
f90cbfa 
…etail using anchor link & managed various scenarios(hotwax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 25, 2024
@R-Sourabh
Improved: added scrolling effecton image instead of whole product det…
4862f1d 
…ails section(hotwax#357)
@R-Sourabh R-Sourabh mentioned this issue Jul 26, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 6, 2024
@R-Sourabh
Improved: added scrolling on image only and updating the detail secti…
a427407 
…on dynamically(hotwax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Improved: onScroll functionality by adding the Intersection Observer …
b62cdfe 
…API to detect items entering the viewport during scrolling(hotwax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Merge branch 'inventory-count-2.0' into hotwax#357-counting-detail-re…
e479c0e 
…vamp
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Improved: upadate variable.css and removed ion import(hotwax#357)
e1bcb28
ymaheshwari1 added a commit that referenced this issue Aug 8, 2024
@ymaheshwari1
Merge pull request #389 from R-Sourabh/#357-counting-detail-revamp
a715c3c 
Implemented: Counting detail page UI Revamp(#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 9, 2024
@R-Sourabh
Improved: added viewSize while fetching items & resolve UI distortion(h…
d0c5a35 
…otwax#357)
@R-Sourabh R-Sourabh mentioned this issue Aug 9, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 12, 2024
@R-Sourabh
Improved: added logic to use the index number instead of seqId when d…
dc1800c 
…isplaying the ratio in the product details section (hotwax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 13, 2024
@R-Sourabh
Improved: simplify the logic of next/previous product button navigati…
6b30e97 
…on by adding a commen function(hotwax#357)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 13, 2024
@R-Sourabh
Merge branch 'inventory-count-2.0' into hotwax#357-product-scrolling
47a1c99
ymaheshwari1 added a commit that referenced this issue Aug 13, 2024
@ymaheshwari1
Merge pull request #427 from R-Sourabh/#357-product-scrolling
adee73b 
Improved: added viewSize while fetching items &  resolve UI distortion(#357)
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Aug 26, 2024
@Adameddy26 Adameddy26 added enhancement New feature or request release-v2.0.0 labels Aug 26, 2024
@Adameddy26
Copy link

Verified and working fine in release v2.0.0. Hence, closing it.
https://jam.dev/c/de141905-c5ef-4098-9f68-88d24904f9ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-v2.0.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravilodhi @dt2patel @R-Sourabh @Adameddy26