-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast message 'Enter a count before saving changes' is not displayed when saving an empty re-count. #397
Labels
Comments
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 2, 2024
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 2, 2024
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 5, 2024
1 task
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 7, 2024
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 7, 2024
…variance on re-count(hotwax#397)
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 8, 2024
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 8, 2024
…digits on input count(hotwax#397)
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 8, 2024
ymaheshwari1
added a commit
that referenced
this issue
Aug 8, 2024
FIxed: on saving the empty re-count a toast will show-up(#397)
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 8, 2024
1 task
ymaheshwari1
added a commit
that referenced
this issue
Aug 8, 2024
Improved: added checks on variance & button & added toast(#397)
R-Sourabh
added a commit
to R-Sourabh/inventory-count
that referenced
this issue
Aug 12, 2024
1 task
ymaheshwari1
added a commit
that referenced
this issue
Aug 13, 2024
Improved: added the changes from productDetail to countDetail component(#397)
Verified and working fine in release v2.0.0. Hence, closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note
Suggestion - When the user clicks the re-count button, the previous count should automatically populate in the count field.
Current behavior
The re-count is saved even if the count field is empty, and no toast message is displayed, allowing incomplete data to be saved.
Expected behavior
A toast message saying "Enter a count before saving changes" should appear when the save button is clicked without a count entered.
The re-count should not be saved until a valid count is provided.
Steps to reproduce the issue
Open the App store view screens and open any count from the assigned tab.
Click on the re-count button in the application.
Attempt to save the re-count without any visible data in the count field.
Observe the issue.
Environment details
App version : INVENTORY-COUNT-2.0-E488779
App environment : DEV
Additional information
https://jam.dev/c/3a09cdf4-fde2-4d3c-ac8a-5a3d26e27128
The text was updated successfully, but these errors were encountered: