Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast message 'Enter a count before saving changes' is not displayed when saving an empty re-count. #397

Closed
Adameddy26 opened this issue Jul 31, 2024 · 1 comment
Closed

Toast message 'Enter a count before saving changes' is not displayed when saving an empty re-count. #397

Adameddy26 opened this issue Jul 31, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.0.0

Comments

@Adameddy26
Copy link

Note

Suggestion - When the user clicks the re-count button, the previous count should automatically populate in the count field.

Current behavior

The re-count is saved even if the count field is empty, and no toast message is displayed, allowing incomplete data to be saved.

Expected behavior

A toast message saying "Enter a count before saving changes" should appear when the save button is clicked without a count entered.
The re-count should not be saved until a valid count is provided.

Steps to reproduce the issue

Open the App store view screens and open any count from the assigned tab.
Click on the re-count button in the application.
Attempt to save the re-count without any visible data in the count field.
Observe the issue.

Environment details

App version : INVENTORY-COUNT-2.0-E488779
App environment : DEV

Additional information

https://jam.dev/c/3a09cdf4-fde2-4d3c-ac8a-5a3d26e27128
@Adameddy26 Adameddy26 added the bug Something isn't working label Jul 31, 2024
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 2, 2024
@R-Sourabh
Merge remote-tracking branch 'upstream/main' into hotwax#397-empty-in…
e02d116 
…put-toast
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 2, 2024
@R-Sourabh
Fixed: toast will appear on saving empty input count(hotwax#397)
bb725db
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 5, 2024
@R-Sourabh
FIxed: on saving the empty re-count a toast will show-up(hotwax#397)
4a851d1
@R-Sourabh R-Sourabh mentioned this issue Aug 5, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 7, 2024
@R-Sourabh
Improved: added toast to show before alert , in case of empty re-coun…
9291448 
…t input(hotwax#397)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 7, 2024
@R-Sourabh
Improved: with prefilled input count , added logic to show prefilled …
eca9ebb 
…variance on re-count(hotwax#397)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Improved: added regex to prevent numbers starting with 0 followed by …
79d6578 
…other digits(hotwax#397)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Reverted: regex to prevent numbers starting with 0 followed by other …
affb064 
…digits on input count(hotwax#397)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Improved: remove the check of product value on the saveCount(hotwax#397)
3c8bc80
ymaheshwari1 added a commit that referenced this issue Aug 8, 2024
@ymaheshwari1
Merge pull request #414 from R-Sourabh/#397-empty-re-count-toast
aeb1cdc 
FIxed: on saving the empty re-count a toast will show-up(#397)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 8, 2024
@R-Sourabh
Improved: added checks on variance & button & added toast(hotwax#397)
9ad2523
@R-Sourabh R-Sourabh mentioned this issue Aug 8, 2024
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Aug 8, 2024
@ymaheshwari1
Merge pull request #426 from R-Sourabh/#397-empty-recount-toast
dc37447 
Improved: added checks on variance & button & added toast(#397)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 12, 2024
@R-Sourabh
Improved: added the changes from productDetail to countDetail component(
2f43491 
hotwax#397)
@R-Sourabh R-Sourabh mentioned this issue Aug 12, 2024
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Aug 13, 2024
@ymaheshwari1
Merge pull request #428 from R-Sourabh/#397-backporting-changes
72aa1cd 
Improved: added the changes from productDetail to countDetail component(#397)
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Aug 26, 2024
@Adameddy26
Copy link
Author

Verified and working fine in release v2.0.0. Hence, closing this issue.
https://jam.dev/c/170345ed-b749-4756-ab96-cb69a7b76e69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.0.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@R-Sourabh @Adameddy26