Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters not working on completed page #420

Open
dt2patel opened this issue Aug 6, 2024 · 4 comments
Open

Filters not working on completed page #420

dt2patel opened this issue Aug 6, 2024 · 4 comments
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.0.0

Comments

@dt2patel
Copy link
Contributor

dt2patel commented Aug 6, 2024

Current behavior

Filter button currently does not show the selected facilities like the Figma designs and also doesn't have support for date range filters:

Screenshot 2024-08-06 at 7 36 14 PM
@dt2patel dt2patel added the bug Something isn't working label Aug 6, 2024
ymaheshwari1 added a commit to ymaheshwari1/inventorycount that referenced this issue Aug 7, 2024
@ymaheshwari1
Implemented: support to display selected facilities in the filters on…
13483af 
… the closed page(hotwax#420)
@ymaheshwari1 ymaheshwari1 mentioned this issue Aug 7, 2024
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Aug 8, 2024
@ymaheshwari1
Merge pull request #423 from ymaheshwari1/#420
d599f53 
Implemented: support to display selected facilities in the filters on the closed page(#420)
@Adameddy26
Copy link

Adameddy26 commented Aug 12, 2024 •
edited
Loading

Verified the changes in DEV environment of App version inventory-count-2.0-dc37447 and found that selected facilities names are visible in the filter pane.
Also the date field is not yet implemented inside the filters due to lack of API support.
Hence, moving this item to planned items.

@dt2patel
Copy link
Contributor Author

Instead of showing all facilities in one item, use one item per facility.

@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Aug 20, 2024 •
edited
Loading

Updated UI:

image

ymaheshwari1 added a commit to ymaheshwari1/inventorycount that referenced this issue Aug 20, 2024
@ymaheshwari1
Improved: UI when displaying selected facilities on the completed pag…
f6e41dc 
…e filter(hotwax#420)
@ymaheshwari1 ymaheshwari1 mentioned this issue Aug 20, 2024
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Aug 20, 2024
@ymaheshwari1
Merge pull request #435 from ymaheshwari1/#420
304ce14 
Improved: UI when displaying selected facilities on the completed page filter(#420)
@dt2patel
Copy link
Contributor Author

looks good to me

@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned ravilodhi Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.0.0
Projects
Digital Experience Platform
Status: 🛠 In QA
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravilodhi @ymaheshwari1 @dt2patel @Adameddy26