Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show "not counted products" for hard counts - Pending Review #564

Closed
dt2patel opened this issue Dec 30, 2024 · 1 comment
Closed

Don't show "not counted products" for hard counts - Pending Review #564

dt2patel opened this issue Dec 30, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.5.2

Comments

@dt2patel
Copy link
Contributor

Current behavior

(Store View) Pending review - Don't show "not counted products" for hard counts

Screenshot 2024-12-29 at 7 15 57 PM
@dt2patel dt2patel added the bug Something isn't working label Dec 30, 2024
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Dec 30, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Dec 30, 2024
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Dec 30, 2024
@amansinghbais
Improved: check for not showing the not counted segment in the hard c…
f4ebeef 
…ount and showing hard count label in pending review cards (hotwax#564)
@amansinghbais amansinghbais mentioned this issue Dec 30, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Dec 30, 2024
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 2, 2025
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/inventory-count into h…
bbf4cf6 
…otwax#564
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 3, 2025
@amansinghbais
Reverted: unnecessary check for not counted items filtering (hotwax#564)
cca4528
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 3, 2025
@amansinghbais
Improved: using scannedId if importItemSeqId is not present in the pr…
8c70f37 
…oduct image key (hotwax#564)
ymaheshwari1 added a commit that referenced this issue Jan 3, 2025
@ymaheshwari1
Merge pull request #569 from amansinghbais/#564
e637baf 
Improved: check for not showing the not counted segment in the hard count and showing hard count label in pending review cards (#564)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 3, 2025
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Jan 14, 2025
@Adameddy26
Copy link

Issue verified and working fine in release v2.5.2. Hence, closing this ticket.
image

@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.5.2
Projects
Digital Experience Platform
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravilodhi @dt2patel @amansinghbais @Adameddy26