Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve facility display logic on Admin user details page #173

Closed
Adameddy26 opened this issue Mar 14, 2024 · 6 comments
Closed

Improve facility display logic on Admin user details page #173

Adameddy26 opened this issue Mar 14, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request release-v1.11.0

Comments

@Adameddy26
Copy link

Description

Currently, on the user details page of an admin user, the message "Added to 0 facilities" is displayed, even though the user has access to all facilities. This inconsistency in the displayed information can lead to confusion and misinterpretation of the user's access privileges. To enhance clarity and accuracy, this enhancement proposes improving the facility display logic to accurately reflect the admin user's access to facilities.

Additional information

https://jam.dev/c/4bd5bc75-bc92-48d2-be92-4544177b8aca

@Adameddy26 Adameddy26 added the enhancement New feature or request label Mar 14, 2024
@Dhiraj1405
Copy link

Will add UI here

@dt2patel
Copy link
Contributor

dt2patel commented Sep 4, 2024

@Adameddy26 can you share if the ability to view all facilities is checked based on a specific permission? Or is it based on security group? I think it's permission, and if so, what is the permission ID that is check.

@Adameddy26
Copy link
Author

@Adameddy26 can you share if the ability to view all facilities is checked based on a specific permission? Or is it based on security group? I think it's permission, and if so, what is the permission ID that is check.

STOREFULFILLMENT_ADMIN - If this permission is given to any group, then each user in that group will be able to perform operations for every facility

@dt2patel dt2patel assigned ravilodhi and unassigned Adameddy26 Sep 4, 2024
@ravilodhi
Copy link
Contributor

@Adameddy26 @dt2patel

What should be the action item here? Should we display the count for all facilities for the admin/super user and disable the modal that opens to manage the user's facilities? If not, what should the behavior of the facilities modal be?

@dt2patel
Copy link
Contributor

dt2patel commented Sep 4, 2024

Sorry looks like I forgot to attach UI:
Screenshot 2024-09-04 at 4 30 15 PM

@ravilodhi ravilodhi assigned R-Sourabh and unassigned ravilodhi Sep 10, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 11, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 11, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 11, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 16, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 16, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 17, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 17, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 17, 2024
R-Sourabh added a commit to R-Sourabh/user-management that referenced this issue Sep 18, 2024
ravilodhi added a commit that referenced this issue Sep 18, 2024
Improved: facility display logic on Admin/Super user details page(#173)
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Sep 27, 2024
@Adameddy26
Copy link
Author

Changes verified and working fine in release v1.11.0. Hence, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-v1.11.0
Projects
Archived in project
Development

No branches or pull requests

5 participants