Redirect to replace_root hits server twice

[MichalSznajder]

Suppose we have in path_configuration:

• /list_items with replace_root, also default URL in app
• /add_item with with default

Let's execute following step

1. App starts with /list_items.
2. User navigates to /add_items
3. Form is submitted and results in redirect to /list_items
4. /list_items is hit and visit is proposed via WebViewBridge
5. Because of path_configuration we end up in NavigationHierarchyController.replaceRoot
6. New visit is initiated with action=replace, redirected flag is ignored
7. NOK: /list_items is hit again (resulting in flash being lost)

[olivaresf]

Hey @MichalSznajder,

New visit is initiated with action=replace, redirected flag is ignored

I suspect this is a known issue that could be fixed with #24. What happens if you try your scenario with that branch?

[MichalSznajder]

It doesn't help. It is better as NavigationHierarchyController.replaceRoot gets proposal with redirected==true but flag is ignored:

hotwire-native-ios/Source/Turbo/Navigator/NavigationHierarchyController.swift

Lines 188 to 195 in 9c7d6c2

	private func replaceRoot(with controller: UIViewController, via proposal: VisitProposal) {
	if let visitable = controller as? Visitable {
	delegate.visit(visitable, on: .main, with: .init(action: .replace))
	}
	navigationController.dismiss(animated: proposal.animated)
	navigationController.setViewControllers([controller], animated: proposal.animated)
	}

I attempted to fix it by passing options created from the proposal, and now the server is no longer being hit twice. Not sure about side effects.

https://github.com/MichalSznajder/hotwire-native-ios/blob/cedea09b969257436f80044e98566f5b7814a05d/Source/Turbo/Navigator/NavigationHierarchyController.swift#L190-L191

[jayohms]

This was resolved in: #60