-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbo Frame reload - no morphing possible? #1127
Comments
I think what would be interesting would be also to have a "frame_refreshes" kind of feature. |
@coorasse have you tried adding the turbo/src/core/drive/morph_renderer.js Lines 80 to 82 in 5902f3b
Here's the relevant commit with a message describing the feature: 9ff6e16 |
@coorasse and @willcosgrove I have this same issue, and I tried the solution that you proposed, Will. Unfortunately, it doesn't work. Specifically, I put refresh="morph" on my frame and then use a link to trigger: Based on reading the PR and testing it, it only does a morph of the frame when the full page is doing a morphing refresh. I just asked a clarifying question on the PR to see if this was an oversight: In the meantime, I'm hunting for a workaround... |
Now that #1192 has been merged and |
I have some turbo frames that are eager/lazy loaded (i.e. they have a
src
attribute).These frames can be reloaded.
The "problem" is that I cannot replace the content using idiomorph, but the frame content is always swapped with a new one.
I believe this is intentional or not planned at the moment, but I'd like to know if this is something that can/should be achieved differently.
Our need is basically to keep the "reloading" mechanism, but be able to swap the content using idiomorph.
The text was updated successfully, but these errors were encountered: