New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbo.Drive: Requiring Confirmation for a Visit not working? #943

Open

tkoenig opened this issue Jul 11, 2023 · 1 comment · May be fixed by #874

tkoenig commented Jul 11, 2023

According to the Documentation one should be able to require a confirmation upon clicking a link.

Unfortunately Im not able to get this to work, is this supposed to work like this?

https://codepen.io/thokthok/pen/QWJaWOR

Author

tkoenig commented Jul 11, 2023

Looks like there is already a PR for this: #874

marcoroth linked a pull request

that will close this issue

Fix data-turbo-confirm on <a> without data-turbo-method #874

Open

searls added a commit to searls/turbo-site that referenced this issue


          Fix inaccurate doc

9fd6bb6

Until hotwired/turbo#874 or hotwired/turbo#1266 resolve hotwired/turbo#1264 and  hotwired/turbo#943, the doc site is wrong and I keep wasting time double-checking it, only for its wrongness to result in me wasting more time debugging Turbo's source code.

searls mentioned this issue

Fix non-working example of data-turbo-confirm without data-turbo-method hotwired/turbo-site#194

Open

searls added a commit to searls/turbo-site that referenced this issue


          Fix inaccurate doc

e2a3fe9

Until hotwired/turbo#874 or hotwired/turbo#1266 resolve hotwired/turbo#1264 and  hotwired/turbo#943, the doc site is wrong and I keep wasting time double-checking it, only for its wrongness to result in me wasting more time debugging Turbo's source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment