From c01c3ba363fc3b1ecde2b5b6379d4b88dc21f356 Mon Sep 17 00:00:00 2001 From: Philipp Sandhaus Date: Sat, 23 Sep 2023 21:22:58 +0200 Subject: [PATCH] Removed checking for valid tx pin for Victron --- src/PinMapping.cpp | 3 +-- src/VictronSmartShunt.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/PinMapping.cpp b/src/PinMapping.cpp index 31cb0f58a..b680edb3e 100644 --- a/src/PinMapping.cpp +++ b/src/PinMapping.cpp @@ -307,8 +307,7 @@ bool PinMappingClass::isValidEthConfig() bool PinMappingClass::isValidVictronConfig() { - return _pinMapping.victron_rx >= 0 - && _pinMapping.victron_tx >= 0; + return _pinMapping.victron_rx >= 0; } bool PinMappingClass::isValidHuaweiConfig() diff --git a/src/VictronSmartShunt.cpp b/src/VictronSmartShunt.cpp index 052f7abd3..86b9c9af2 100644 --- a/src/VictronSmartShunt.cpp +++ b/src/VictronSmartShunt.cpp @@ -13,7 +13,7 @@ bool VictronSmartShunt::init(bool verboseLogging) MessageOutput.printf("[VictronSmartShunt] Interface rx = %d, tx = %d\r\n", pin.battery_rx, pin.battery_tx); - if (pin.battery_rx < 0 || pin.battery_tx < 0) { + if (pin.battery_rx < 0 ) { MessageOutput.println(F("[VictronSmartShunt] Invalid pin config")); return false; }