Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

tidy: fix W0221 arguments-differ #1877

Open
reidpr opened this issue Mar 22, 2024 · 0 comments
Open

tidy: fix W0221 arguments-differ #1877

reidpr opened this issue Mar 22, 2024 · 0 comments

Comments

@reidpr
Copy link
Collaborator

reidpr commented Mar 22, 2024

Split from #1860. Pylint: W0221 arguments-differ

For example, superclass:

class Instruction(abc.ABC):

def checkout_for_build(self, base_image=None):

Subclass:

class Instruction_No_Image(Instruction):

charliecloud/lib/build.py

Lines 634 to 635 in d679373

def checkout_for_build(self):
pass

This violates Liskov substitution principle and should be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant