-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to move vsc.install to its own repo #194
Comments
@JensTimmerman @boegel toughts? |
I don't see the big advantage of fleshing it out into a separate repo/pkg, introducing our own dependency in vsc-base just so we can install/test it is weird? Adding scripts for the Jenkins unit tests here still makes sense though. |
here's a good reason: stdweird@7cd32b5 (and some of it's implications you're probably not aware of) |
OK, I guess that is a good reason. And indeed, since it's only a build dependency for vsc-base, it's OK-ish (and will lead to a cleaner vsc-base repo/install). So: +1 on fleshing out This does imply having both |
@stdweird: What other implications are you referring to btw? Is there more going on that just making sure that |
how does this solve anything? Aren't you just moving the problem? |
yes, but only in that file and it will be a build_requires for vsc-base (i mean it's ok to have the hack for vsc.install, but is a but to coarse for vsc-base) |
surely it will also be |
only |
installation requires it, you need it to run |
any objections? the repo could also hold wrppers for running the jenkins unittests, whihc are unreviewed and look funny
The text was updated successfully, but these errors were encountered: