Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MIME subtype for html mail #341

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
with:
python-version: ${{ matrix.python }}
- name: install tox
run: pip install tox
run: pip install 'virtualenv<20.22.0' 'tox<4.5.0'
- name: add mandatory git remote
run: git remote add hpcugent https://github.com/hpcugent/vsc-base.git
- name: Run tox
Expand Down
2 changes: 1 addition & 1 deletion lib/vsc/utils/mail.py
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ def sendHTMLMail(

# Record the MIME types of both parts - text/plain and text/html_message.
msg_plain = MIMEText(text_alternative, 'plain', 'utf-8')
msg_html = MIMEText(html_message, 'html_message', 'utf-8')
msg_html = MIMEText(html_message, "html", 'utf-8')

# Attach parts into message container.
# According to RFC 2046, the last part of a multipart message, in this case
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
from vsc.install.shared_setup import ag, kh, jt, sdw

PACKAGE = {
'version': '3.5.3',
'version': '3.5.4',
'author': [sdw, jt, ag, kh],
'maintainer': [sdw, jt, ag, kh],
'install_requires': [
Expand Down