Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be sensible defaults for filters wherever possible #144

Open
bhaddow opened this issue Jan 10, 2024 · 1 comment
Open

There should be sensible defaults for filters wherever possible #144

bhaddow opened this issue Jan 10, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bhaddow
Copy link
Contributor

bhaddow commented Jan 10, 2024

Often adding a filter fails, because there are no default arguments passed to the filter function. For example many functions require source and target language and this could be set globally at a corpus level. Because it isn't, this requires fiddling with the dropdowns for many of the filters, and reading obscure error messages.

@jelmervdl
Copy link
Collaborator

Related to #45.

Filters do support static default arguments already, but it looks like I never bothered setting good defaults 🤦

@jelmervdl jelmervdl added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants