Skip to content
This repository has been archived by the owner on Jul 31, 2019. It is now read-only.

Pdf file is now printed in the correct path #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cderv
Copy link

@cderv cderv commented Nov 11, 2018

this fixes #8.

It follows PR #7 and currently contains its fix from chrome_version. It must be merged after.

Proposal:

  • pass the output path to --print-to-pdf=<output> instead of copying and renaming.
  • By default, chrome headless overwrite. I left you mechanism to add number to output filename if overwrite=FALSE

Should work on all system. It is working on windows now - I did not test on other system.


This change is Reviewable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On windows, pdf file is not moved when using chrome_dump_pdf
1 participant