Use keyword_pattern for is_symbol check
#1975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbode
changed the title
keyword_pattern for is_symbol check
joshbode
force-pushed
the
joshbode/keyword-symbol-check
branch
from
ba7b2b0
to
ccd371a
Compare
|
with this change: 
without the change, no matches |
joshbode
force-pushed
the
joshbode/keyword-symbol-check
branch
from
ccd371a
to
7fcfde7
Compare
joshbode
force-pushed
the
joshbode/keyword-symbol-check
branch
from
7fcfde7
to
c525b32
Compare
joshbode
force-pushed
the
joshbode/keyword-symbol-check
branch
from
c525b32
to
c124724
Compare
joshbode
force-pushed
the
joshbode/keyword-symbol-check
branch
from
c124724
to
1d2f68a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
keyword_patternin place ofchar.is_symbolto improve matching (especially useful for improving forcmp-pathandcmp-cmdlinematches in the command-line).Falls back to original behaviour of using
char.is_symbolif nokeyword_patternis provided/specified for a source.