-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control_msgs ROS1<->ROS2 fails ros1_bridge build #4
Comments
Could the first error be caused by 084ed7f? |
Could you please provide an easy-to-reproduce example? Did you make any changes in Dockerfile or created a new mapping_rules.yaml? |
Sure, here you go: Click to expandFROM ros:galactic-ros-base-focal
# setup sources.list
RUN echo "deb http://packages.ros.org/ros/ubuntu focal main" > /etc/apt/sources.list.d/ros1-latest.list
# setup keys
RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys C1CF6E31E6BADE8868B172B4F42ED6FBAB17C654
ENV ROS1_DISTRO noetic
ENV ROS2_DISTRO galactic
# install ros packages
RUN apt-get update && apt-get install -y --no-install-recommends \
ros-noetic-ros-comm \
ros-noetic-roscpp-tutorials \
ros-noetic-rospy-tutorials \
ros-noetic-sensor-msgs \
ros-noetic-control-msgs \
ros-noetic-trajectory-msgs \
ros-galactic-control-msgs \
ros-galactic-sensor-msgs \
ros-galactic-trajectory-msgs \
git \
&& rm -rf /var/lib/apt/lists/*
RUN mkdir -p /bridge_ws/src
WORKDIR /bridge_ws/src
RUN git clone https://github.com/ipa-hsd/ros1_bridge.git -b action_bridge
WORKDIR /bridge_ws
RUN . /opt/ros/${ROS2_DISTRO}/setup.sh \
&& apt-get update \
&& rosdep update --include-eol-distros \
&& rosdep install --from-paths src --ignore-src -r -y \
&& colcon build --symlink-install --packages-skip ros1_bridge \
&& . /opt/ros/${ROS1_DISTRO}/setup.sh \
&& . install/local_setup.sh \
&& rosdep update --include-eol-distros && rosdep install --from-paths src --ignore-src -r -y \
&& colcon build --symlink-install --packages-select ros1_bridge --cmake-force-configure --cmake-args -DBUILD_TESTING=FALSE -DCMAKE_BUILD_TYPE=RelWithDebInfo
See above.
I haven't touched nor created any. |
Added this commit and now it builds for me: ros2@79a46de Could you please try again? |
Though I get this error
But it is a mapping error (might need mapping_rules.yaml), the code itself should hopefully be fixed now. |
It does now indeed build for me as well. Output of Click to expand
|
I'll close this, as the immediate issue has been resolved. 👍 @ipa-hsd. Thanks for the help. |
are there more issues you have noticed? |
No, nothing right now. But I also haven't used the new build yet. I'll let you know. |
First: 💯 for the work.
With your recent updates to ros2#256, I tried building a configuration where both ROS 1 and ROS 2 have
control_msgs
,sensor_msgs
andtrajectory_msgs
installed.The build comes quite far, but at some point it stops with the following output:
this repeats for all
actions
incontrol_msgs
.Additionally:
I don't remember seeing these earlier, so perhaps these are the result of a recent addition?
The text was updated successfully, but these errors were encountered: