Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brainstorming more petty things to snark on? #1

Open
stuartpb opened this issue Jan 22, 2019 · 1 comment
Open

Brainstorming more petty things to snark on? #1

stuartpb opened this issue Jan 22, 2019 · 1 comment

Comments

@stuartpb
Copy link

stuartpb commented Jan 22, 2019

Here are some of my own personal pet peeves:

  • Using Harmony language features without "use strict" (I am fully guilty of this one on a regular basis, and I realize it every time I deploy to an Ubuntu LTS system where Node is older than ~6.x)
  • Using === in a situation where you actually want equality to be checked on a type-coercive basis (though I have no idea how you'd gauge this based on the AST)
  • Various complaints about whitespace:
    • Mixing tabs and spaces
    • Whitespace at end of line
    • No newline at end of file
    • Lines that don't use whitespace in any place where it'd be valid ("why are you postprocessing this if you've already minified it?")
    • Entire lines that use whitespace in every place it could be valid (eg. new Date ( 1989 , 5 , 28 ) . toISOString ( ))

Also, what about a config option to decide whether the processor complains about using semicolons, or not using semicolons?

@makc
Copy link

makc commented Sep 27, 2019

variable names in 2...5 range that arent real words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants