Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reading job ad #61

Closed
matyasselmeci opened this issue Apr 21, 2023 · 3 comments
Closed

Stop reading job ad #61

matyasselmeci opened this issue Apr 21, 2023 · 3 comments

Comments

@matyasselmeci
Copy link
Collaborator

matyasselmeci commented Apr 21, 2023

We read and parse the job ad file in main.go:parse_job_ad() for getting Owner and ProjectName info of the job. We used to send that to monitoring but no longer do as of #50.

That function crashes if $_CONDOR_JOB_AD is set to a non-existent or unreadable file, but instead of fixing it we should just remove the parse_job_ad().

@djw8605
Copy link
Collaborator

djw8605 commented Apr 21, 2023

We use it in the #41, but it can certainly be improved.

@matyasselmeci
Copy link
Collaborator Author

Ah, fair enough. In that case, we should just fix that crash.

@matyasselmeci
Copy link
Collaborator Author

Closing in favor of #62.

@matyasselmeci matyasselmeci closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants