Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ember-cli-changelog #58

Open
eriktrom opened this issue Apr 20, 2018 · 5 comments
Open

add ember-cli-changelog #58

eriktrom opened this issue Apr 20, 2018 · 5 comments

Comments

@eriktrom
Copy link
Member

It includes babel 5.x in its dependencies. Fixing this should allow using it again here and in ember-gestures

wild guess atm

@RobbieTheWagner
Copy link
Member

@runspired do we want to just deprecate ember-cli-changelog? It needs a lot of work, and I don't understand the code well enough to implement the changes.

@eriktrom
Copy link
Member Author

To be honest this was my thinking as well. I could have tried to fix changelog, but it’s very old and I was wondering what other addons are using instead.

@RobbieTheWagner
Copy link
Member

Most addons use lerna-changelog these days, I think. I loved the ember-cli-release and ember-cli-changelog ease of use, but would need help from @runspired to get it working well.

@eriktrom
Copy link
Member Author

Not gonna lie, i just made 3 releases of ember-gestures manually, b/c it broke an app i asked someone to try it on. Thus I made 3 manual tags, 3 manual releases, 3 manual commit messages, 3 of everything. I borked one thing, which isn't a big deal, there's no 0.6.0 in the commit line of master, and it's message which really only travis saw said 'Released 0.4.8' b/c that's where I tagged 0.6.0 from, during the revert. Then I published a sem ver safe 1.0.0

This story shows that we need a tool back badly, i don't care which one.

I'll do the implementation. Let me know whether to fix ember-cli-changelog or use something else :)

@runspired
Copy link
Collaborator

I’ll poke at things tomorrow 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants