Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-types::Response::new might panic #348

Open
mihai-dinculescu opened this issue Aug 1, 2022 · 0 comments
Open

http-types::Response::new might panic #348

mihai-dinculescu opened this issue Aug 1, 2022 · 0 comments

Comments

@mihai-dinculescu
Copy link

mihai-dinculescu commented Aug 1, 2022

The current implementation of http-types::Response::new will panic on non-standard error codes such as the 52x ones returned by Cloudflare.

It looks like instead of returning an Ok(Response::new(res.into())), the send function should first test the StatusCode with StatusCode::try_from::<u16>.

I have also created an issue in http-types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant