Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of multiple search phrases against a single page? #36

Open
mlewis-everley opened this issue Jul 22, 2020 · 4 comments
Open

Comments

@mlewis-everley
Copy link
Contributor

I was just wondering is this a feature that would be of interest?

I am thinking it might be fairly simple to move the search phrase field and related score into a gridfield linked to the page and display the results for each additional phrase in this gridfield editform.

I know some of our clients ask for this functionality and it would improve the ability to improve the visibility of their post for multiple searches.

@hubertusanton
Copy link
Owner

That would be a great feature for the module i think.
Wondering how to do this with gridfield/ editform

@mlewis-everley
Copy link
Contributor Author

If you had a SearchPhrase DataObject that is related to SiteTree, it should be possible to copy/move the "search phrase", "star rating" and tips to the seperate ItemEditForm.

I think the JS for the rating field will need to be re-written a bit, so rather than requiring a custom script in GoogleSearchField::Field we instead load some generic JS globally and add some data attributes to the field to tell the JS what to do (this would also fix an issue I am seeing that requires users to refresh the page in order to get the star rating field to work).

I think it might also be a good idea to move some of the code in SeoObjectExtension into a separate Utility\Helper, that way the algorithms for calculating the various things can be called from multiple places.

@hubertusanton
Copy link
Owner

Ok, let's do it. I can review it or help if you'd like.

@mlewis-everley
Copy link
Contributor Author

I am going to try and put aside some time this week to look into it, so lets see how I get on.

Any chance you can let know what you think about issue #13? As I might try and do a PR for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants