Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive error logging for parsing issues #589

Open
GriffinRichards opened this issue Jan 19, 2024 · 0 comments
Open

Excessive error logging for parsing issues #589

GriffinRichards opened this issue Jan 19, 2024 · 0 comments

Comments

@GriffinRichards
Copy link
Collaborator

Some parsing errors result in multiple logs that don't add new information. Example for trying to open wild encounters if the file is missing:

<timestamp> [ERROR] Could not open '<path>/wild_encounters.json': No such file or directory
<timestamp> [ERROR] Error: Failed to parse json file <path>/wild_encounters.json: unexpected end of input
<timestamp>  [WARN] Failed to read wild encounters from <path>/wild_encounters.json

ParseUtil should probably expose error messages to the caller and allow them to handle the details. The example above should look something like:

<timestamp>  [WARN] Failed to read wild encounters from '<path>/wild_encounters.json': No such file or directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant