No warning shown when user attempts to create a map with an invalid name

[tabbbywright]

So this tool is absolutely lovely, but I'd love if Porymap had a feature where if a user was naming a map, and their name was invalid, that it would confirm BEFORE making the map with an alternate name. If I'd been warned, I would've told Porymap NOT to proceed with the rename, and come up with another naming convention.

Basically how this went:

• I go to make a new map, and I want it grouped with the Mt. Pyre maps, so I try to name it like this: [24.15.A1] MtPyre_0F with A1 being what I'll label all of my custom maps.
• Porymap doesn't like this naming convention (my bad) and renames my map to [0.57] A1MtPyre_0F
  I don't like this, and it will be difficult for me to keep things organized thusly...
• I look for a way in Porymap to delete the badly named map, find that I can't.
• I then look for a way to rename the map, find that I can't do that either (not easily anyway)
• I google how to delete maps in Porymap, wondering what I'm missing in the UI, and find that I can't and that's deliberate (and understandable, honestly)
• I try to rename everything in the appropriate configuration files but inevitably miss things
• I give up, and discard my changes in git to get rid of the badly named map

Apologies if this is something that's specified in the documentation and I overlooked it (I've read some, but not all of it yet).

Thanks for your time!

[GriffinRichards]

Thanks! This seems more like a bug (or a regression, if I'm remembering correctly that this used to work). You're right, Porymap shouldn't let you set invalid map names.

For some clarity on what you were trying to do, the [24.15] before the map name is not part of the map name. This is Porymap showing you the values for the map group and map number. These are the values in include/constants/map_groups.h, and are not editable via Porymap.

If you'd like to ensure a map is sorted alongside another map:

• In the popup when you're creating the map, select the same Group as the map you want to group it with. In your case, this is gMapGroup_Dungeons, where all the other Mt. Pyre maps are.

After you create the map it'll be appended to the group you selected. You don't need to worry about the numbers, but for more clarity gMapGroup_Dungeons is map group 24, and if you look in the map list you'll notice all the maps in this group are prefixed [24.##]. By default your new map would automatically get the prefix [24.108], and be next to the last map in the list MeteorFalls_StevensCave. If you'd then like to move your map within this group, e.g. to be above MtPyre_1F, then:

• Save and close Porymap after creating the map
• Open the data/maps/map_groups.json file in your project
• Find MtPyre_0F (or whatever you named your new map), delete it, and insert it where in the list you'd like it to be. Make sure the list doesn't end with a comma.

    "FieryPath",
+   "MtPyre_0F",
    "MtPyre_1F",
 ...
    "AlteringCave",
-    "MeteorFalls_StevensCave",
-    "MtPyre_0F"
+    "MeteorFalls_StevensCave"

• Save your changes to this file. You can then reopen Porymap.

The ability to move maps like this within Porymap is already a planned feature for the next release. And as a final clarification, yes unfortunately Porymap is not able to fully support deleting or renaming maps.

[tabbbywright]

Wow! Thank you so much for the wonderfully detailed response! I did assume after the initial forced-rename that the [24.15] was not something I had control over (at least not at this level) but I appreciate you taking the time to confirm + elaborate. I'll remember this for the future!

And EXTRA thank you for explaining how I can reorder my maps. I got the new one made (with the correct name this time) but it definitely wasn't where I wanted it in the list--but now I can fix it!

As for deleting/renaming: I completely understand--I am plenty happy just to know that in future versions, I will have a chance to fix my map name BEFORE it's set in stone.

Since you mentioned this might be a bug, here's a little more info on my environment in case it's relevant:
- Porymap Version 5.4.1
- Porygon Dark Theme (though I think I was on the default light one at the time)
- Windows 10 Home Version 10.0.19045 Build 19045

One other thing I'm wondering about: When I check for updates, I get the following message: Failed to check for version update: Protocol https is unknown

Is this a known issue? Let me know if I should open an issue for it.

Thanks again!

[GriffinRichards]

No that's not a known issue, thanks for the report. It's possible we need to create a new static Windows build that links OpenSSL. The Check for Updates feature is relatively new, and it's mostly only been tested on dynamically linked builds. Unfortunately I'm also on macOS, so someone else will have to fix that.