Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload Some Tasks To Secondary Thread #641

Open
IAGOnGithub opened this issue Nov 15, 2024 · 3 comments
Open

Offload Some Tasks To Secondary Thread #641

IAGOnGithub opened this issue Nov 15, 2024 · 3 comments

Comments

@IAGOnGithub
Copy link

Most, if not all, tasks seem to run on the same thread. While this is fine in many cases, some intensive tasks will cause the GUI to lag significantly as rendering is delayed. Ideally, this shouldn't happen. Some tasks should be offloaded to a separate worker thread to let the main thread (where application rendering takes place) run without significant interruptions.

This issue might be a duplicate. I searched "thread" in the issue tracker and nothing came up.

@GriffinRichards
Copy link
Collaborator

What was causing Porymap to lag significantly? (I'd be surprised if there wasn't lower-hanging fruit to address before we'd want to turn to threading)

@IAGOnGithub
Copy link
Author

Bulk selecting metatiles is the big one, and then (sometimes) when editing tilesets.

@GriffinRichards
Copy link
Collaborator

👍 Selecting metatiles from the map is about as inefficient as it can be (it's creating and rendering an entirely new set of images for every update of the selection rectangle) so there's definitely some easier ways to improve the speed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants