Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event elevation defaults to 0 #643

Open
GriffinRichards opened this issue Nov 17, 2024 · 0 comments
Open

Event elevation defaults to 0 #643

GriffinRichards opened this issue Nov 17, 2024 · 0 comments

Comments

@GriffinRichards
Copy link
Collaborator

GriffinRichards commented Nov 17, 2024

Should investigate the games to see if it makes more sense to use the standard default elevation (3) or to use the elevation of the underlying map space the event is created on (or even update the elevation as it's moved?).

In either case the code is a little misleading, we set the default elevation to the elevation from the new map fill settings, but this is never actually used because all of the Event classes override setDefaultValues

EDIT: After checking how the games handles this, it looks like the order of preference for defaults should roughly be elevation of map space they're positioned on > 0 > 3. In general the games will override the elevation in the event data with the elevation of the map space, but it could be possible to get a situation where the event's elevation disagrees with the map space (which -- with exception to bridges -- it probably shouldn't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant