Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetadataInfo class is not testable #76

Open
developerdizzle opened this issue Oct 7, 2016 · 0 comments
Open

MetadataInfo class is not testable #76

developerdizzle opened this issue Oct 7, 2016 · 0 comments

Comments

@developerdizzle
Copy link

While attempting to write some unit tests in another project, I came across the need to construct a MetadataInfo object. Unfortunately, its constructor is private and its Create methods are internal.

Ideally, I would like to be able to mock this class like any other "dumb" model. My larger goal here is to mock VideoStream and AudioStream objects that have particular metadata properties, that I can use in unit tests for methods that perform sanity checks against these streams.

I could certainly submit a PR to make the constructor and Create properties more accessible, but I'm not sure that's the best approach here, and was hoping to start some discussion around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant