Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beating Best Constant Rebalanced Portfolio #441

Open
sword134 opened this issue Aug 5, 2020 · 6 comments
Open

Beating Best Constant Rebalanced Portfolio #441

sword134 opened this issue Aug 5, 2020 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@sword134
Copy link

sword134 commented Aug 5, 2020

Is it realistic that when running an exponential gradient model I am beating the best constant rebalanced portfolio return on the same timeframe? I thought that the BCRP was the creme de la cremé of investing and it couldn't be better, so how come that I am getting a EG model which has a higher return with the exact same data and timeframe?

@Jackal08
Copy link
Member

Jackal08 commented Aug 5, 2020

Hi @sword134,

I invite you to join our Slack Channel, it's a great place to ask questions and get community feedback.

Alternatively, if you dive into the source code and find a bug, please do raise the issue here and we can look into it.

Right now, these types of questions would require a large time investment on our side to get reacquainted with the literature.

@Jackal08 Jackal08 self-assigned this Aug 5, 2020
@sword134
Copy link
Author

sword134 commented Aug 5, 2020

@Jackal08 i've found the bug. I use yfinance to get the data and there was an error in one of the tickers where it suddenly dropped 80% or so in value and did a full recovery the next day (didn't happen irl)

@sword134 sword134 closed this as completed Aug 5, 2020
@Jackal08
Copy link
Member

Jackal08 commented Aug 5, 2020

Ah, great to know its not on our side, thanks.

@sword134
Copy link
Author

sword134 commented Aug 5, 2020

@Jackal08 actually having sorted out the dataset issue, the best constant rebalanced portfolio returns are still smaller than the ones I get using an EG. Therefore I am reopening the issue.

@sword134 sword134 reopened this Aug 5, 2020
@sword134
Copy link
Author

sword134 commented Aug 6, 2020

When looking at the returns it will sometimes return over 100% while there is no where near that big increase in any of the assets its allowed to trade, how can this be?

@sword134
Copy link
Author

sword134 commented Aug 6, 2020

@Jackal08 for example, when I am looking at the returns and calculate the difference between each day of returns (I am training a daily model for the example) I can see that one of the days it went from 7,37 to 7,05 there by losing -0,31 (31%). When I look at the assets it was in invested in for that day I can see it had 99% of its portfolio in 1 stock, this stock on the same day "only" lost -14% of its value, so how come its showing a completely wrong number in returns?

@Jackal08 Jackal08 added the help wanted Extra attention is needed label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants