Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cache for openai models. #435

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JoelNiklaus
Copy link
Contributor

@JoelNiklaus JoelNiklaus commented Dec 11, 2024

Fixes Issue 414 by adding a diskcache to the openai backend.

@clefourrier
Copy link
Member

I can't test this one so it will wait for Nathan to come back - however, you'll also need to add diskcache to our requirements, and I'm not sure we want to expand them so much

@clefourrier clefourrier requested a review from NathanHB December 12, 2024 10:07
@JoelNiklaus
Copy link
Contributor Author

In case you don't want to add diskcache to your requirements, what alternative do you see? Or does that mean that we don't do any caching?

@NathanHB
Copy link
Member

Thanks for the solutions ! I will be reviewing this tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FT] Adding diskcache
3 participants