[llama] Store KV Cache on CPU and Use PyTorch SPDA for Next token generation
#1182
Conversation
|
@hshen14 @luoyu-intel for awareness |
|
@mandy-li @libinta @dvarshney-habana This is the first PR of system optimization from intel neural compressor(INC) team, could you give a review? Experiments of Llama2 on single Gaudi2 card with Xeon 8380 host. With offloading KV Cache and SDPA to CPU, we improve the context limit from 26k(input:10k+output:16k) to 310k(input:10k+output:300k).
|
zhentaoyu
requested review from
ssarkar2,
bhargaveede,
vivekgoe,
mandy-li and
libinta
as code owners
|
Please sync your PR with main/upstream and fix any merge conflicts. Thank you. |
done. |
|
@zhentaoyu this PR also has merge conflict with main, could you please take a look at the differences? |
|
|
Hi, @imangohari1, I have updated the PR (see descriptions). Could you please retake a look when you have free time? Please let me know if you have more comments or need more tests. Thanks a lot. |
| else: | ||
| unwrap_deepspeed_model(self).allocate_kv_cache( | ||
| bs * generation_config.num_beams, calculated_max_length, token_idx + num_virtual_tokens | ||
| ) |
There was a problem hiding this comment.
From line 1096 to 1107, I would like to suggest to change like this.
if not is_greedy_or_beam_and_bucket:
cache_device = "hpu"
if generation_config.kv_cache_on_host and self.config.model_type in ["llama"]:
print("Allocate KV Cache on CPU...")
cache_device = "cpu"
unwrap_deepspeed_model(self).allocate_kv_cache(
bs * generation_config.num_beams, calculated_max_length, token_idx + num_virtual_tokens,
device=cache_device
)
There was a problem hiding this comment.
Thanks, I have updated it in 74e94ff. However, I can not remove the else line because I only modified the modeling_llama.py for this experimental feature.
|
@zhentaoyu Do you have a use case for "It's an option for long-context inference or generation when a single hpu card OOM." ? |
Hi @yeonsily, thanks for your comment. Yes, I add a case in README and update the results in the PR description. |
| else: | ||
| with ht.sdp_kernel(enable_recompute=flash_attention_recompute): | ||
| else: | ||
| if kv_cache_on_host: |
There was a problem hiding this comment.
Can you please explain what's the case switching kv_cache device? I thought line 656 is the case only when line 658.
There was a problem hiding this comment.
In this pr, we make kv cache store on cpu and do cpu sdpa only when generating the next token. The first token or prefill stage is performed on HPU due to its powerful computation ability under long-context scenario (long prompt in most cases). The full pipeline diagram shows on the pr description.
So line 658 tells the machine it can do pytorch-cpu sdpa (flash-attn) only when kv_cache_on_host & in next-token generation & inference stage. Otherwise, it will transfer the kv-cache to hpu device if need for its original operations.
Please let me know if you need more explanations or have some suggestions. Thanks.
@yeonsily the similiar features already available in tensorrt-llm https://nvidia.github.io/TensorRT-LLM/kv_cache_reuse.html#offloading-to-host-memory |
|
@zhentaoyu Can you please rebase your change? We can merge this change after that. |
Yes, rebased. Thanks a lot. |
|
@yeonsily Anything else needed before merging? |
|
@airMeng Can you please run all of the llama CI test to make sure this doesn't impact the current numbers? You can check the llama CI cases from https://github.com/huggingface/optimum-habana/tree/main/tests folder. Thanks. |
|
hi @yeonsily the CI/CD set on github can't be triggered? |
|
Hi, @yeonsily, I have run the llama model test cases in if os.environ.get("GAUDI2_CI", "0") == "1":
# Gaudi2 CI baselines
MODELS_TO_TEST = {
"bf16_1x": [
("meta-llama/Llama-2-7b-hf", 1, True, 141.25776956002076, True),
("meta-llama/Meta-Llama-3-8B", 1, True, 129, False),
("meta-llama/Llama-2-7b-hf", 512, True, 12808, False),
("meta-llama/Llama-2-7b-hf", 512, False, 8711, False), # in some cases like TGI, reuse_cache isnt used
],
"fp8": [
("meta-llama/Llama-2-7b-hf", 1, 1230, False, 128, 128, 13152.7),
("meta-llama/Llama-2-7b-hf", 1, 163, False, 128, 2048, 4774.7),
("meta-llama/Llama-2-7b-hf", 1, 94, False, 2048, 128, 1293.3),
("meta-llama/Llama-2-7b-hf", 1, 81, False, 2048, 2048, 1942.9),
],
"load_quantized_model_with_autogptq": [
("TheBloke/Llama-2-7b-Chat-GPTQ", 1, 10, False, 128, 2048, 456.7),
],
"torch_compile": [
("meta-llama/Llama-2-7b-hf", 102.27823420713148),
],
"torch_compile_distributed": [
("meta-llama/Llama-2-7b-hf", 39.72973199515235),
],
"distributed_tp": [
("meta-llama/Llama-2-7b-hf", 1345.2369318328463),
],
}the running command is results: the whole test log is here: |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@zhentaoyu CI didn't pass, can you take a look at this error? https://github.com/huggingface/optimum-habana/actions/runs/12149024129/job/33878873264?pr=1182#step:4:370 |
|
@zhentaoyu You will need this change to fix the CI failure. Meanwhile, I think you should also try llama training cases if your change doesn't affect the perf number. It seems you ran only inference case. |
Fixed, thanks. As for training test, I test this function called test_multiple_peft_adapters locally since it using the |
|
@zhentaoyu Can you also run the Llama training regression tests with please? |
ok. Will update here if I get the result. |
|
Hi, @regisss, I meet the error like below when using pip list: |
|
The code quality check failed, please run |
Signed-off-by: Yu Zhentao <[email protected]>
Signed-off-by: Yu Zhentao <[email protected]>
Signed-off-by: Yu Zhentao <[email protected]>
Signed-off-by: Yu Zhentao <[email protected]>
Signed-off-by: Yu Zhentao <[email protected]>
Signed-off-by: Yu Zhentao <[email protected]>
Signed-off-by: Yu Zhentao <[email protected]>
What does this PR do?
Results
python run_generation.py --model_name_or_path meta-llama/Llama-2-7b-hf --max_new_tokens 4096 --bf16 --use_kv_cache --attn_softmax_bf16 --reuse_cache --do_sample --prompt "Tell me somethings about Intel"--kv_cache_on_host```bash Stats: -------------------------------------------------------------------------------------------------------------- Throughput (including tokenization) = 2.132539697795915 tokens/second Number of HPU graphs = 14 Memory allocated = 12.68 GB Max memory allocated = 12.77 GB Total memory available = 94.62 GB Graph compilation duration = 5842.699780527037 seconds~~ -------------------------------------------------------------------------------------------------------------- ```update 4b0fa1a
--kv_cache_on_hostLimitations
--use_hpu_graphsbecause it has host-device memory transfer in the self-attn forward process.cc @airMeng and @luoyu-intel
Update
Yi-34b-chaton gaudi-2 with ~11k input + 5k outputcommand:
python run_generation.py \ --model_name_or_path 01-ai/Yi-34B-Chat \ --use_kv_cache \ --bf16 \ --attn_softmax_bf16 \ --reuse_cache \ --do_sample \ --dataset_name emozilla/pg19-test \ --batch_size 1 \ --max_input_tokens 11200 \ --column_name "text" \ --dataset_max_samples 1 \ --warmup 0 \ --n_iterations 1 \ --max_new_tokens 5000 \ --kv_cache_on_hostkv_cache_on_host:kv_cache_on_host:Stats: ---------------------------------------------------------------------- Throughput (including tokenization) = 1.2790787964372536 tokens/second Total runtime for dataset: 3909.073683977127 Memory allocated = 90.72 GB Max memory allocated = 91.63 GB Total memory available = 94.62 GB Graph compilation duration = 3907.185397926951 seconds ----------------------------------------------------------------------kv_cache_on_host:--max_input_tokens 11200 --max_new_tokens 10000Stats: ---------------------------------------------------------------------- Throughput (including tokenization) = 1.2790787964372536 tokens/second Total runtime for dataset: 3909.073683977127 Memory allocated = 90.72 GB Max memory allocated = 91.63 GB Total memory available = 94.62 GB Graph compilation duration = 3907.185397926951 seconds ----------------------------------------------------------------------