Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating SharedDDP caused failure on Optimum. #1441

Closed
4 tasks
AdamLouly opened this issue Oct 9, 2023 · 1 comment
Closed
4 tasks

Deprecating SharedDDP caused failure on Optimum. #1441

AdamLouly opened this issue Oct 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AdamLouly
Copy link
Contributor

System Info

optimum nightly
transformers nightly

Who can help?

Problem:

SharedDDP has been deprecated in the transformers library, but it is still being used in the optimum examples. This is causing failures in the examples, and we need to address this issue.

Question:

Are you actively working on fixing this problem, or should I go ahead and create a PR to resolve this issue?

Additional Inquiry:

In the interest of maintaining compatibility and preventing future issues, can you provide insight into how changes in the transformers library are being tested to ensure they do not impact optimum examples going forward?

@JingyaHuang

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction (minimal, reproducible, runnable)

run any optimum example.

Expected behavior

Getting these errors.

AttributeError: 'Trainer' object has no attribute 'use_cuda_amp'
or
is_fairscale_available failed to be imported from transformers.integration.

@AdamLouly AdamLouly added the bug Something isn't working label Oct 9, 2023
@JingyaHuang
Copy link
Contributor

Close as it's fixed via #1443, thanks again for fixing it @AdamLouly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants