Swin V2 #1147
-
Hi, first of all, thanks for all the amazing work. I just reimplemented a version of the Swin Transformer V2 (no official implementation currently available) and I would like to push it to timm, making it easier accessible for others. What should I be aware of before opening a pull request (would be my first timm pull request)? My code is available here. Thanks in advance! |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
@ChristophReich1996 I looked at your impl, it's nice and clean. You added the defmorable variant which is nice. I'm open to a PR with a few notes
So, next steps would be:
Re style, yours is clean as mentioned, the most significant thing I'd end up changing is indent alignment, I generally don't like to align multiple lines of args, etc from opening brackets, but align next line on standard indent as I find it much easier to maintain over long term (with diffs, etc). |
Beta Was this translation helpful? Give feedback.
@ChristophReich1996 I looked at your impl, it's nice and clean. You added the defmorable variant which is nice. I'm open to a PR with a few notes
swin_...._v2
names for that as they will come with a full set of pretrained weights. Perhapsswin_large..._v2_cr
orcr_swin_large...v2
(your initials, to differentiate)So, next steps would be:
timm
style and registration, create model helpers, interface