-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pyarrow arrays as input #1535
Conversation
|
pulling |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave the dep as optional wdyt?
makes sense, will get it changed @ArthurZucker |
i've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to avoid having to use git for the repo 😢
ALso do you have any bench / examples of it being use and fast? 🚀
yeah will update that once there is a stable release of arrow ( |
Good afternoon everyone. How do you think the optimal benchmark should look like? Native pyarrow vs numpy conversion for string arrays? |
something like that yeah, I have no idea in what context pyarrow is used as I have not used it, but in optimal context usage |
I'm not sure it should be closed. The pr is looking fine. |
yes, just update to arrow to the latest stable version |
closes #1415