Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use BaseModelOutput as common interface for all different BaseModelOutputWith*? #11013

Open
JoanFM opened this issue Apr 1, 2021 · 0 comments
Labels
Feature request Request for a new feature

Comments

@JoanFM
Copy link

JoanFM commented Apr 1, 2021

Hello team,

I have been taking a look at the different output models from your models, and I wonder if it would make sense to inherit all the BaseModelOutputWithPool and all the other flavours of modeling output, instead of using ModelOutput.

class BaseModelOutput(ModelOutput):

We are trying to build a wrapper around many of the public models hosted on hugging face, and it would be useful to know if we can assume that all the potential outputs of the models will contain hidden_states. Since now they all only inherit from ModelOutput it seems a little confusing.

Am I missing something? Is it not something that can be assumed?

@JoanFM JoanFM changed the title use BaseModelOutput as common interface for all different ModelOutputs use BaseModelOutput as common interface for all different BaseModelOutputWith*? Apr 1, 2021
@LysandreJik LysandreJik added the Feature request Request for a new feature label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants