Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed MllamaPreTrainedModel._prepare_4d_causal_attention_mask #35920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

changed MllamaPreTrainedModel._prepare_4d_causal_attention_mask #35920

wants to merge 1 commit into from

Conversation

AndriiZelenko
Copy link

@AndriiZelenko AndriiZelenko commented Jan 27, 2025 •
edited
Loading

Resolves Issue #35918 (comment), for detailed info please refer to issue, that one documented well

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @amyeroberts, @qubvel

@AndriiZelenko AndriiZelenko marked this pull request as draft January 27, 2025 22:38
@AndriiZelenko AndriiZelenko marked this pull request as ready for review January 27, 2025 22:39
@Rocketknight1
Copy link
Member

Hi @AndriiZelenko, I believe this is already being fixed in a larger PR here: #35763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndriiZelenko @Rocketknight1