Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an option to auto close update page after update #110

Open
peter-lyons-kehl opened this issue Mar 25, 2021 · 12 comments
Open

Have an option to auto close update page after update #110

peter-lyons-kehl opened this issue Mar 25, 2021 · 12 comments

Comments

@peter-lyons-kehl
Copy link

The update popup can be annoying. Please add an option not to show it (but still to update).

@Folyd
Copy link
Member

Folyd commented Mar 26, 2021

That's weird. Auto-opening the update page is disabled by default. You can disable the auto-update in the popup pages if it has been open accidentally.

image

@peter-lyons-kehl
Copy link
Author

This request is not about enabling/disabling auto-update by default.

Instead, I'm asking for a new option/checkbox: Do auto-update, but don't show any popup.

@Folyd
Copy link
Member

Folyd commented Mar 29, 2021

This request is not about enabling/disabling auto-update by default.

Instead, I'm asking for a new option/checkbox: Do auto-update, but don't show any popup.

I'm afraid we can't achieve silence auto-update due to the API limitation of the browser. See this issue #97.

@peter-lyons-kehl
Copy link
Author

peter-lyons-kehl commented Mar 29, 2021

Could you change the URL of the auto-update page to something like https://rust.extension.sh/update?auto-close=true, and make it close itself? Or make it open in a hidden tab (and make it close itself), please?

@aminya
Copy link

aminya commented Sep 19, 2021

Yeah, this extension randomly opens a new page every now and then, although I did not ask for it.

@Folyd
Copy link
Member

Folyd commented Sep 19, 2021

Hi @aminya. Thanks for reporting. Could you please check the Enable auto update is turned off?

image

@aminya
Copy link

aminya commented Sep 19, 2021

It was enabled for me. Why is it necessary to open a new tab for auto updating? There should be a way to do it without this

@Folyd
Copy link
Member

Folyd commented Sep 19, 2021

There has a declaration about the intent of auto-update on the update page. See #97.
image

@nihaals
Copy link

nihaals commented Nov 22, 2021

Maybe this should be renamed to auto close update page after update?

@nihaals
Copy link

nihaals commented Nov 22, 2021

Also it would be nice to have this be a separate setting toggle as some users might be confused/concerned by a tab quickly opening and closing, similar to Windows and random cmd.exe windows.

@peter-lyons-kehl peter-lyons-kehl changed the title Have an option not to show the update popup Have an option to auto close update page after update Nov 23, 2021
@Folyd Folyd closed this as completed Oct 19, 2022
@nihaals
Copy link

nihaals commented Oct 20, 2022

Was this implemented or is this closed as incomplete?

@peter-lyons-kehl
Copy link
Author

https://addons.mozilla.org/en-US/firefox/addon/rust-search-extension/versions and https://github.com/huhu/rust-search-extension/releases show a new version. But https://github.com/huhu/rust-search-extension/commits/master doesn't show any commit message mentioning auto closing the update tab/window. Yet to see.

@Folyd Folyd reopened this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants