Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The editor should not allow users to create multiple links between a pair of nodes #17

Open
daisukes opened this issue Aug 23, 2023 · 7 comments
Open

The editor should not allow users to create multiple links between a pair of nodes #17

daisukes opened this issue Aug 23, 2023 · 7 comments

Comments

@daisukes
Copy link
Contributor

If there are multiple links between Node A and B, some navigation logic may break.
It is difficult to find multiple links between a certain pair of nodes.
@itohtaka
Copy link

@kentarou-fukuda Do you have any comments?

@itohtaka
Copy link

If we forbid this operation, we will not be able to create links like the following
image

@itohtaka
Copy link

More practical links
image

@itohtaka
Copy link

Maybe "The editors should not allow users to create multiple linear links between pairs of nodes." is correct.

@itohtaka
Copy link

We plan to modify the createLink() function to generate an error if a linear link already exists.

@daisukes
Copy link
Contributor Author

Thank you! It sounds good!

@itohtaka
Copy link

Fixed in the latest push.
894d28f
e2663d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itohtaka @daisukes