Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't this use normal string formatting? #2

Open
jack-t opened this issue May 3, 2014 · 4 comments
Open

Why doesn't this use normal string formatting? #2

jack-t opened this issue May 3, 2014 · 4 comments

Comments

@jack-t
Copy link
Member

jack-t commented May 3, 2014

In the SimpleLogger.log() method, there's this whole thing that reads the string and gives it additional information. Practically every other system out there uses printf-style formatting, which is provided by String.format. Is there a reason you chose not to use this?

@ttaylorr
Copy link
Contributor

ttaylorr commented May 3, 2014

I was being silly. Can you patch this in logger?
On May 3, 2014 9:10 AM, "Jack" [email protected] wrote:

In the SimpleLogger.log() method, there's this whole thing that reads the
string and gives it additional information. Practically every other system
out there uses printf-style formatting, which is provided by String.format.
Is there a reason you chose not to use this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2
.

@jack-t
Copy link
Member Author

jack-t commented May 3, 2014

Already have. We'll have to rewrite all the logging usages, but that's easy.

@ttaylorr
Copy link
Contributor

ttaylorr commented May 3, 2014

No, there's a better way. Let's wait till I get home.
On May 3, 2014 9:15 AM, "Jack" [email protected] wrote:

Already have. We'll have to rewrite all the logging usages, but that's
easy.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-42104777
.

@jack-t
Copy link
Member Author

jack-t commented May 3, 2014

Wait to do what? Make the string formatter normal or rewrite the logging thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants