Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide images in Media Library look messy and can be scaled up to fit the thumb display height #212

Open
joehoyle opened this issue Jan 27, 2022 · 3 comments

Comments

@joehoyle
Copy link
Member

Due to how we have this "no max width" on images, it looks pretty bad when you have very wide images. I don't know if this change from the WP Media Library change was at the request of @noeltock, or how we got to have this, but IMO it's pretty terrible.

Screen Shot 2022-01-27 at 16 06 59

@roborourke
Copy link
Contributor

Cheers Joe. That specific image in your screenshot does indeed look bad, we probably need a maximum width we would show, especially as this looks like it's blown up to match the height displayed.

I think the initial goal was to have something like masonry or like how flickr displays images.

The problem it aimed to solve was in cases where users had multiple versions of the same or similar image with different crops, they would otherwise all be shown as a square thumbnail. I know Tachyon handles this but it can still happen easily, especially if using the inline cropper in the block editor.

Your example is a bit of an exception but agree we should handle it more nicely than that. I'll scope this issue a bit to handling very wide images.

@roborourke roborourke changed the title Media Library is very messy and difficult to scan Wide images in Media Library look messy and can be scaled up to fit the thumb display height Jan 27, 2022
@joehoyle
Copy link
Member Author

Yeah I think the screenshot above is the worst-case, but would also like to at least be one voice that says that the masonry approach I don't think is a good one for productivity. Especially as we actually have a horizontal stack, so we're not able to use all the horizontal space.

IMO if we want to not show crops, we should have fixed size containers, and then we have the image resized to "max-width: 100pxl max-height: 100px" style.

@roborourke
Copy link
Contributor

100x100 squares are a bit small to cram letterboxed images into so id probably go a bit bigger if we do this. Would be good to get some more voices in the mix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants