Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope to slur when adding slur #102

Open
craigsapp opened this issue Jun 1, 2018 · 3 comments
Open

Scope to slur when adding slur #102

craigsapp opened this issue Jun 1, 2018 · 3 comments
Assignees

Comments

@craigsapp
Copy link
Member

When adding a slur, such as when typing s while focused on a note, the scope is shifted to the last note of the slur rather than the slur. It should be put on the slur.

@craigsapp craigsapp self-assigned this Jun 1, 2018
@craigsapp
Copy link
Member Author

craigsapp commented Jun 5, 2018

Fixed with commit 041e438

slur

Interactions done:

(1) click on second note (D4)
(2) type 4s to add a slur that extends to the 4th note after the current note.
(3) press the right arrow to move the left end of the slur
(4) press shift-right arrow to move the right end of the slur
(5) then doing some more moving and pressing a and b to force the slur above/below the staff.

@craigsapp
Copy link
Member Author

Needs to be fixed again

@craigsapp craigsapp reopened this Jun 21, 2019
@craigsapp
Copy link
Member Author

Or more precisely, when editing a slur, moving the start of the slur behaves correctly, with the slur remaining in focus. But when moving the ending of the slur, the focus on the slur is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant