-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples with HB2-beta.5 #80
Conversation
tib
commented
May 22, 2024
•
edited
Loading
edited
- updated all the examples (except ios-image-server)
- Package.swift unification (use 5.9, remove unsafe flags, dep versions, etc.)
- remove git unnecessary submodule from auth-srp
- add other useful scripts for checks & format support
todos-mongokitten-openapi/Sources/todos-mongokitten-openapi/API.swift
Outdated
Show resolved
Hide resolved
todos-mongokitten-openapi/Sources/todos-mongokitten-openapi/API.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this seems to be personal preference (removing .git
from dependencies, adding a Makefile.
Files have also been reformatted because they have been formatted with swift-format.
I would like to do my own investigation with "-cross-module-optimization" before removing it. So far I haven't seen anything significant to indicate it should be removed, apart from one forum post where tests ran slower.
+1 to Using HTTPClient.shared
+1 to updating Package.swift where required
+1 to fixing compile errors
Can we remove the additional scripts for the moment and we can discuss in a separate PR what is needed there
The updated todos-fluent is cool, but a separate PR would be preferable
@tib not sure if this is related to your changes, but it looks like the mongo example isn't working. It might just be because it has no tests. If you could add an empty test target that'd be great. |
Sure thing, I can do that, also should I separate the Fluent example in an other PR or is it fine if it stays in this one? |
Nah you can leave it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍