Skip to content

Commit

Permalink
Template updates (Swift 5.7)
Browse files Browse the repository at this point in the history
  • Loading branch information
adam-fowler committed Nov 22, 2022
1 parent f95e192 commit 185004f
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 6 deletions.
22 changes: 22 additions & 0 deletions .github/workflows/api-breakage.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# This will be interesting to see how often AWS break there own APIs
name: API breaking changes

on:
pull_request:

jobs:
linux:
runs-on: ubuntu-latest
container:
image: swift:5.7
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
# https://github.com/actions/checkout/issues/766
- name: Mark the workspace as safe
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}
- name: API breaking changes
run: |
swift package diagnose-api-breaking-changes origin/${GITHUB_BASE_REF}
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
strategy:
matrix:
image:
- 'swift:5.4'
- 'swift:5.5'
- 'swift:5.6'
- 'swift:5.7'

container:
image: ${{ matrix.image }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
image: ['nightly-bionic', 'nightly-focal', 'nightly-centos8', 'nightly-amazonlinux2']
image: ['nightly-bionic', 'nightly-focal', 'nightly-jammy', 'nightly-amazonlinux2']

container:
image: swiftlang/swift:${{ matrix.image }}
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.DS_Store
/.build
.build/
/.swiftpm
/.vscode
/.devcontainer
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ Please ensure to include the following in your Pull Request
- Documentation on how these changes are being tested
- Additional tests to show your code working and to ensure future changes don't break your code.

Remember the requirements for Hummingbird and HummingbirdCore (No Foundation and no new dependencies). If you are submitting a change to one of the other modules which requires a new dependency please consider to make these changes in a separate repository. These concerns can be discussed in a Github Issue.
Remember the requirements for Hummingbird and HummingbirdCore (No Foundation and no new dependencies). If you are submitting a large change to a module (or bringing in a new dependency) please consider making these changes in a separate repository. The idea is that Hummingbird/HummingbirdCore are kept as slimline as possible. These concerns can be discussed in a Github Issue.

Please keep your PRs to a minimal number of changes. If a PR is large try to split it up into smaller PRs. Don't move code around unnecessarily it makes comparing old with new very hard.

The main development branch of the repository is `main`.

### Formatting

We use Nick Lockwood's SwiftFormat for formatting code. PRs will not be accepted if they haven't be formatted. The current version of SwiftFormat we are using is v0.48.17.
We use Nick Lockwood's SwiftFormat for formatting code. PRs will not be accepted if they haven't be formatted. The current version of SwiftFormat we are using is v0.48.17.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ================================
# Build image
# ================================
FROM swift:5.4 as build
FROM swift:5.7 as build

WORKDIR /build

Expand Down

0 comments on commit 185004f

Please sign in to comment.