From 185004fdce8d2e5d9dd69547d0a04357e65f7825 Mon Sep 17 00:00:00 2001 From: Adam Fowler Date: Tue, 22 Nov 2022 14:19:27 +0000 Subject: [PATCH] Template updates (Swift 5.7) --- .github/workflows/api-breakage.yml | 22 ++++++++++++++++++++++ .github/workflows/ci.yml | 2 +- .github/workflows/nightly.yml | 2 +- .gitignore | 2 +- CONTRIBUTING.md | 4 ++-- Dockerfile | 2 +- 6 files changed, 28 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/api-breakage.yml diff --git a/.github/workflows/api-breakage.yml b/.github/workflows/api-breakage.yml new file mode 100644 index 0000000..bf82786 --- /dev/null +++ b/.github/workflows/api-breakage.yml @@ -0,0 +1,22 @@ +# This will be interesting to see how often AWS break there own APIs +name: API breaking changes + +on: + pull_request: + +jobs: + linux: + runs-on: ubuntu-latest + container: + image: swift:5.7 + steps: + - name: Checkout + uses: actions/checkout@v3 + with: + fetch-depth: 0 + # https://github.com/actions/checkout/issues/766 + - name: Mark the workspace as safe + run: git config --global --add safe.directory ${GITHUB_WORKSPACE} + - name: API breaking changes + run: | + swift package diagnose-api-breaking-changes origin/${GITHUB_BASE_REF} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d01a9a3..6a76c42 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,9 +38,9 @@ jobs: strategy: matrix: image: - - 'swift:5.4' - 'swift:5.5' - 'swift:5.6' + - 'swift:5.7' container: image: ${{ matrix.image }} diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 84def5d..2807361 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -17,7 +17,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - image: ['nightly-bionic', 'nightly-focal', 'nightly-centos8', 'nightly-amazonlinux2'] + image: ['nightly-bionic', 'nightly-focal', 'nightly-jammy', 'nightly-amazonlinux2'] container: image: swiftlang/swift:${{ matrix.image }} diff --git a/.gitignore b/.gitignore index c3297d7..dec7450 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,5 @@ .DS_Store -/.build +.build/ /.swiftpm /.vscode /.devcontainer diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 674d2e7..12d20a0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,7 +22,7 @@ Please ensure to include the following in your Pull Request - Documentation on how these changes are being tested - Additional tests to show your code working and to ensure future changes don't break your code. -Remember the requirements for Hummingbird and HummingbirdCore (No Foundation and no new dependencies). If you are submitting a change to one of the other modules which requires a new dependency please consider to make these changes in a separate repository. These concerns can be discussed in a Github Issue. +Remember the requirements for Hummingbird and HummingbirdCore (No Foundation and no new dependencies). If you are submitting a large change to a module (or bringing in a new dependency) please consider making these changes in a separate repository. The idea is that Hummingbird/HummingbirdCore are kept as slimline as possible. These concerns can be discussed in a Github Issue. Please keep your PRs to a minimal number of changes. If a PR is large try to split it up into smaller PRs. Don't move code around unnecessarily it makes comparing old with new very hard. @@ -30,4 +30,4 @@ The main development branch of the repository is `main`. ### Formatting -We use Nick Lockwood's SwiftFormat for formatting code. PRs will not be accepted if they haven't be formatted. The current version of SwiftFormat we are using is v0.48.17. +We use Nick Lockwood's SwiftFormat for formatting code. PRs will not be accepted if they haven't be formatted. The current version of SwiftFormat we are using is v0.48.17. \ No newline at end of file diff --git a/Dockerfile b/Dockerfile index cce40b6..01fa447 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,7 +1,7 @@ # ================================ # Build image # ================================ -FROM swift:5.4 as build +FROM swift:5.7 as build WORKDIR /build