Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript Organization #73

Open
miklb opened this issue Aug 30, 2019 · 2 comments
Open

Javascript Organization #73

miklb opened this issue Aug 30, 2019 · 2 comments
Assignees
@miklb

Comments

@miklb
Copy link
Contributor

miklb commented Aug 30, 2019

Issue Overview

The Map javascript was ported from previous work done during Florence and Michael. To prepare for work on #15 the inline JS should be better organized and run through Gulp task to minimize for production.
@miklb miklb self-assigned this Aug 30, 2019
@miklb
Copy link
Contributor Author

miklb commented Aug 30, 2019

Looking through some approaches at how others have done it, this post javascript is written as .js files in assets/js. Gulp processes those and saves them into _includes/generated and then liquid includes that in the layout file.

@miklb
Copy link
Contributor Author

miklb commented Sep 4, 2019

After going down a couple of rabbit holes with babel and terser, I'm of the idea that this should coincide with a full refactor of the map code. The use of site. config variables adds an additional layer of complexity extracting out the javascript.

The Gulp workflow to use .js files and then generate a compressed version to include inline with the HTML works as planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miklb miklb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miklb