-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat Excalidraw files as attachments #68
Comments
Having a lot of empty drawings feels counter-intuitive to me, however I can also see why one would need it. |
Sorry, I kinda misread your initial isuse. Could you provide a working example so that I can try to replicate it on my end? |
Just a heads up that I've pushed a patch to disable cleanup of Excalidraw file for now (v1.1.1). |
Hi! |
I have attached a typical note. This has embedded Excalidraw drawings that are 'blank' to start. In case someone is like "why?" - I have a hotkey to "swap" between the Obsidian text entry view and the Excalidraw "drawing" view - its kinda like Obsidian is one side of the "paper" where I type notes, and Excalidraw is the back side of the paper where you can draw images. Then hot-key back and forth at will. I hope this helps. This attached files is one of the files and the content that the previous version tried to delete. |
Aha that is actually a really nice way of using it :) I will spend some more time looking into the implementation for cleaning up Excalidraw files. |
Hi, I've now made a pre-release version with a fixed version of the original implementation (v1.1.2-0). It now does a pre-check to see if it has any backlinks / references (this was the part that was missing from the original implementation) and if so, skips the cleanup for that particular Excalidraw file. On my end it seem to work as intended, but I would like for you to give it a shot to if possible, either in a test vault or your main. Once BRAT has been installed and enabled, go to the settings tab for the plugin and click You'll see it in BRAT shortly after adding it, like this. You can confim the version in the community plugin tab Once installed, see if it works as you expect. Finally: To remove the beta version, disable / uninstall BRAT, then re-install File Cleaner Redux through the community plugin listing. Thanks in advance |
I found a bug which cause a rather big slowdown since it was trying to parse markdown files twice, this has now been pushed to 1.1.2-1, the procedure above is still correct except for the version to test is now |
I have a lot of empty Excalidraw drawings embedded in my notes. I do this in case I want to draw a picture in a note, so every meeting note contains an empty Excalidraw drawing.
When I ran this plugin today, ANY file - even if it has other content like text or images - was flagged for deletion because they contain empty Excalidraw files.
REQUEST: please allow a setting to TURN THIS OFF!!!!
Here is an example - all of these were flagged for deletion - but - they all have content (and have empty Excalidraw content).
The text was updated successfully, but these errors were encountered: