Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't report test failures #786

Open
kyouko-taiga opened this issue Jul 25, 2023 · 4 comments
Open

CI doesn't report test failures #786

kyouko-taiga opened this issue Jul 25, 2023 · 4 comments

Comments

@kyouko-taiga
Copy link
Contributor

See https://github.com/val-lang/val/actions/runs/5651732864/job/15310295464#step:5:5679
@dabrahams
Copy link
Collaborator

Working on this; see #787

@peter-evans
Copy link
Contributor

I tested with this branch in my fork: main...peter-evans:hylo:tests-fail-ci

The devcontainer and macos builds correctly failed, but windows did not.
https://github.com/peter-evans/hylo/actions/runs/7491585476/job/20393135728

I'm not sure if it's a different issue to this one, or something new.

@dabrahams
Copy link
Collaborator

Keep in mind that not all tests run on Windows because of #1289
Is that perhaps why you're not seeing the failures?

@peter-evans
Copy link
Contributor

Ah, yes. This causes the test to just pass without executing it.

In that case, perhaps this issue can be closed because the other builds seemed to report test failures fine. There are other issues open for windows build related problems. e.g. #252 and #1289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dabrahams @kyouko-taiga @peter-evans