Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In memory images for textures. #851

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

In memory images for textures. #851

wants to merge 1 commit into from

Conversation

ikeough
Copy link
Contributor

@ikeough ikeough commented Aug 7, 2022

BACKGROUND:
The API for creating textures for materials in Elements currently takes a relative file path and writes an image file to disk internally. This will not work for wasm scenarios where disk i/o operations are forbidden.

DESCRIPTION:
This pull request adds two new APIs to Material, enabling the user to build materials from byte[] and from Image<Rgba32> objects. Additionally, it extends the current relative path support to more robust Uri support, including absolute and relative file paths using file://, and protocols like http:// and https://.

image

TESTING:

  • New tests are added that get images from the web to be used as textures.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Copy link
Contributor

@serenayl serenayl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@ikeough ikeough modified the milestones: 0.2.1, 2.1 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants