Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

feature: Officially support overriding the default namespace #2

Open
gmaclennan opened this issue Dec 13, 2021 · 1 comment
Open

feature: Officially support overriding the default namespace #2

gmaclennan opened this issue Dec 13, 2021 · 1 comment

Comments

@gmaclennan
Copy link

Currently the default namespace is the hash of '@corestore/namespace'. This can be overridden by passing opts._namespace, but the _ prefix suggests this is a private undocumented option (used for creating namespaced hypercores). Overriding the default namespace would be useful for migrating existing hypercores or controlling what the namespace is.

This change would mean changing the option from opts._namespace to opts.namespace and documenting opts.namespace as a supported option.

Nuhvi added a commit to Nuhvi/corestore-next that referenced this issue Apr 14, 2022
use opts.namespace instead opts._namespace

 add documentation to
opts.namespace

BREAKING CHANGE: undocumented opts._namespace won't work anymore

Closes hypercore-protocol#2
Nuhvi added a commit to Nuhvi/corestore-next that referenced this issue Apr 14, 2022
use opts.namespace instead opts._namespace

 add documentation to
opts.namespace

BREAKING CHANGE: undocumented opts._namespace won't work anymore

Closes hypercore-protocol#2
@Nuhvi
Copy link
Contributor

Nuhvi commented Apr 20, 2022

opts.namespace is ready in 6385474

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants