From d96b3e1db49ced4908b29ec2d682b95c89061a03 Mon Sep 17 00:00:00 2001 From: Budhi <964106+sapiderman@users.noreply.github.com> Date: Mon, 12 Feb 2024 14:39:27 +0700 Subject: [PATCH] Update to Node to v20.x (#1235) * update to node 20x * update base docker image * update package and lock --- .github/workflows/auto-pr-schemastore.yml | 2 +- .github/workflows/docker-release-from-tag.yml | 2 +- .github/workflows/docs-build.yml | 2 +- .github/workflows/docs.yml | 4 ++-- .github/workflows/nightly-release.yml | 2 +- .github/workflows/node.js.yml | 20 +++++++++---------- .../workflows/npm-notification-publish.yml | 4 ++-- .github/workflows/npm-publish.yml | 6 +++--- .github/workflows/publish-snap.yml | 4 ++-- .github/workflows/upload-binary.yml | 4 ++-- Dockerfile | 2 +- Dockerfile.flyio | 2 +- package-lock.json | 2 +- package.json | 10 +++++----- 14 files changed, 33 insertions(+), 33 deletions(-) diff --git a/.github/workflows/auto-pr-schemastore.yml b/.github/workflows/auto-pr-schemastore.yml index bdda7cc71..d3e4f8c42 100644 --- a/.github/workflows/auto-pr-schemastore.yml +++ b/.github/workflows/auto-pr-schemastore.yml @@ -43,7 +43,7 @@ jobs: - name: ✍🏻 Setup node uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - name: Run Test on Schema run: | diff --git a/.github/workflows/docker-release-from-tag.yml b/.github/workflows/docker-release-from-tag.yml index b4fcac496..9669ae18e 100644 --- a/.github/workflows/docker-release-from-tag.yml +++ b/.github/workflows/docker-release-from-tag.yml @@ -27,7 +27,7 @@ jobs: - name: 🔧 Setup Node uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - name: 📥 Install Dependencies run: npm ci diff --git a/.github/workflows/docs-build.yml b/.github/workflows/docs-build.yml index 80a3f9015..f6032aeba 100644 --- a/.github/workflows/docs-build.yml +++ b/.github/workflows/docs-build.yml @@ -36,7 +36,7 @@ jobs: - name: ✍🏻 Setup node uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - name: 📥 Install deps run: npm install --legacy-peer-deps diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 061a7d9c4..e68c2a841 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -37,7 +37,7 @@ jobs: - name: ✍🏻 Setup node uses: actions/setup-node@v4 with: - node-version: 16.14 + node-version: 20.x - name: 📥 Install deps run: npm ci @@ -69,7 +69,7 @@ jobs: - name: ✍🏻 Setup node uses: actions/setup-node@v4 with: - node-version: 16.14 + node-version: 20.x - name: 📥 Install deps run: npm ci diff --git a/.github/workflows/nightly-release.yml b/.github/workflows/nightly-release.yml index f7879ba74..59d78aea2 100644 --- a/.github/workflows/nightly-release.yml +++ b/.github/workflows/nightly-release.yml @@ -29,7 +29,7 @@ jobs: - name: 🔧 Setup Node uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - name: 📥 Install Dependencies run: npm ci diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 48def7565..6c0e47d57 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -22,10 +22,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 18.x + - name: Use Node.js 20.x uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm run lint @@ -36,10 +36,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 18.x + - name: Use Node.js 20.x uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm run format @@ -50,10 +50,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 18.x + - name: Use Node.js 20.x uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm pack @@ -66,10 +66,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 18.x + - name: Use Node.js 20.x uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm pack @@ -84,10 +84,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Use Node.js 18.x + - name: Use Node.js 20.x uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm test && npx codecov diff --git a/.github/workflows/npm-notification-publish.yml b/.github/workflows/npm-notification-publish.yml index 7924f03a5..c665e3d0d 100644 --- a/.github/workflows/npm-notification-publish.yml +++ b/.github/workflows/npm-notification-publish.yml @@ -22,7 +22,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm pack @@ -35,7 +35,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x registry-url: https://registry.npmjs.org/ - run: npm ci - run: npm run build -w packages/notification diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 76681bbc0..47674e216 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm test @@ -31,7 +31,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: npm ci - run: npm run build -w packages/notification - run: npm pack @@ -45,7 +45,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x registry-url: https://registry.npmjs.org/ - run: npm ci - run: npm run build -w packages/notification diff --git a/.github/workflows/publish-snap.yml b/.github/workflows/publish-snap.yml index 8fe027999..d2c5b1f52 100644 --- a/.github/workflows/publish-snap.yml +++ b/.github/workflows/publish-snap.yml @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: npm ci name: Install dependencies - run: npm run build -w packages/notification @@ -38,7 +38,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: npm ci --workspaces --if-present name: Install workspaces dependencies - run: npm run build --workspaces --if-present diff --git a/.github/workflows/upload-binary.yml b/.github/workflows/upload-binary.yml index 7a846666a..f609ad7aa 100644 --- a/.github/workflows/upload-binary.yml +++ b/.github/workflows/upload-binary.yml @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: npm ci name: Install dependencies - run: npm run build -w packages/notification @@ -58,7 +58,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20.x - run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//} name: Get version diff --git a/Dockerfile b/Dockerfile index 881eba7ed..c3c9e08e7 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:18-alpine AS builder +FROM node:20-alpine AS builder WORKDIR /monika diff --git a/Dockerfile.flyio b/Dockerfile.flyio index aca9bcece..36ece83ac 100644 --- a/Dockerfile.flyio +++ b/Dockerfile.flyio @@ -1,4 +1,4 @@ -FROM node:18-alpine +FROM node:20-alpine RUN apk add --no-cache --virtual .gyp python3 make g++ diff --git a/package-lock.json b/package-lock.json index 5c0270080..774079ddf 100644 --- a/package-lock.json +++ b/package-lock.json @@ -113,7 +113,7 @@ "typescript": "5.1.6" }, "engines": { - "node": ">=18.0.0" + "node": ">=20.0.0" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/package.json b/package.json index 8868fcb06..a1f68dd3d 100644 --- a/package.json +++ b/package.json @@ -159,7 +159,7 @@ "singleQuote": true }, "engines": { - "node": ">=18.0.0" + "node": ">=20.0.0" }, "files": [ "/bin", @@ -196,9 +196,9 @@ "node_modules/sqlite3/lib/binding/**/*" ], "targets": [ - "node18-linux-x64", - "node18-macos-x64", - "node18-win-x64" + "node20-linux-x64", + "node20-macos-x64", + "node20-win-x64" ], "patches": { "./node_modules/thread-stream/lib/worker.js": [ @@ -213,7 +213,7 @@ "outputPath": "dist" }, "volta": { - "node": "18.14.0" + "node": "20.11.0" }, "workspaces": [ "packages/*"